feat(android): modern Material 3 bottom navigation for TabView#11212
feat(android): modern Material 3 bottom navigation for TabView#11212NathanWalker wants to merge 1 commit intomainfrom
Conversation
|
View your CI Pipeline Execution ↗ for commit 4563f45
☁️ Nx Cloud last updated this comment at |
|
This does not supersede or replace community's material components, this just provides the baseline to give best of class on both platforms out of the box since TabView already uses modern iOS API's with glass and on bottom - this now provides consistent expectations to both. |
|
I think this is a bit sudden and doesn't feel very practical to add a heavy dependency like material just for TabView. https://github.com/NativeScript/NativeScript/blob/main/packages/ui-mobile-base/android/widgets/src/main/java/org/nativescript/widgets/BottomNavigationBar.java This link is from BottomNavigation back then: |
|
|
I believe only other alternate view is to just remove all ui components from core and make them all ad hoc pick your own one at a time for each project which there’s a good case for that if clear and easy enough to browse best in class options altogether in official docs. Plan bigger move like that for v10 or v11. |
|
I agree 100% with @CatchABus and it was my first thought when I saw the PR.
I do believe this PR should not get in. |
|
Let's close this, we'll continue chats in discord on the ui decoupling. |
androidTabsPosition="bottom"now renders viacom.google.android.material.bottomnavigation.BottomNavigationViewwith the M3 active-indicator pill and an 80dp layout, replacing the bottom-pinned TabLayout.TabViewacross iOS and Android provide the best of class result on either and consistent experience (with regards to orienting bottom)ns-material3-android-bottom-tabs.mov