Skip to content

changed int_max_str_digits from -1 to 4300 to be more cpython complient#5343

Merged
youknowone merged 2 commits into
RustPython:mainfrom
JamesClarke7283:int-max-str-digits-fix
Jun 27, 2024
Merged

changed int_max_str_digits from -1 to 4300 to be more cpython complient#5343
youknowone merged 2 commits into
RustPython:mainfrom
JamesClarke7283:int-max-str-digits-fix

Conversation

@JamesClarke7283
Copy link
Copy Markdown
Contributor

@JamesClarke7283 JamesClarke7283 commented Jun 24, 2024

A basic fix, which changes sys.flags.int_max_str_digits to 4300 instead of -1 so it behaves the same as the cpython implementation. Fixes #5139

PS: this is my first issue and I am new here, do let me know if I missed anything.

@JamesClarke7283
Copy link
Copy Markdown
Contributor Author

JamesClarke7283 commented Jun 25, 2024

Why did the test_cmd_line test fail?

Strange, I only changed one number, to meet the spec.

@youknowone
Copy link
Copy Markdown
Member

youknowone commented Jun 25, 2024 •
edited
Loading

You need to look in each test details to get more idea.

UNEXPECTED SUCCESS: test_int_max_str_digits (test.test_cmd_line.CmdLineTest.test_int_max_str_digits)

You actually fixed it!
Please remove the top expectedFailure decorator to mark it successful test.