Fix fetching packages from private repositories#261
Open
nnobelis wants to merge 5 commits intoaboutcode-org:mainfrom
Open
Fix fetching packages from private repositories#261nnobelis wants to merge 5 commits intoaboutcode-org:mainfrom
nnobelis wants to merge 5 commits intoaboutcode-org:mainfrom
Conversation
nnobelis
force-pushed
the
nnobelis/fix_fetching_packages_from_private_repositories
branch
9 times, most recently
from
01ab6d6 to
e2fa598
Compare
nnobelis
force-pushed
the
nnobelis/fix_fetching_packages_from_private_repositories
branch
3 times, most recently
from
76bf1e9 to
c470994
Compare
nnobelis
force-pushed
the
nnobelis/fix_fetching_packages_from_private_repositories
branch
2 times, most recently
from
4e78be2 to
d77b915
Compare
If a private repository is specified, the package metadata should be fetched from it, not from pypi.org. Please note the limitation that querying from multiple private repositories is currently not supported. Fixes aboutcode-org#260. Signed-off-by: Nicolas Nobelis <nicolas.nobelis@bosch.com>
URLs to private repositories usually contain credentials. Signed-off-by: Nicolas Nobelis <nicolas.nobelis@bosch.com>
Some artifactories (e.g. JFrog), return relative URLs in the package metadata. This commit canonicalizes them to compare them. Signed-off-by: Nicolas Nobelis <nicolas.nobelis@bosch.com>
…cess Some artifactories (e.g. JFrog), return URLs ending by an anchor, e.g. to carry the source artifact hash. To make the comparison work, remove those URL fragments. Signed-off-by: Nicolas Nobelis <nicolas.nobelis@bosch.com>
nnobelis
force-pushed
the
nnobelis/fix_fetching_packages_from_private_repositories
branch
from
d77b915 to
2480998
Compare
Signed-off-by: Nicolas Nobelis <nicolas.nobelis@bosch.com>
nnobelis
force-pushed
the
nnobelis/fix_fetching_packages_from_private_repositories
branch
from
d192bfc to
863b166
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a private repository is specified, the package metadata should be
fetched from it, not from pypi.org.
Fixes #260.
The changes in this PR have been tested with a private repository and without, i.e. fetching package metadata from pypi.org is still working with the changes.