perf(forms): avoid spurious recomputation in FormField.parseErrors#68624
Open
arturovt wants to merge 1 commit intoangular:mainfrom
Open
perf(forms): avoid spurious recomputation in FormField.parseErrors#68624arturovt wants to merge 1 commit intoangular:mainfrom
arturovt wants to merge 1 commit intoangular:mainfrom
Conversation
thePunderWoman
requested review from
alxhub and
leonsenft
and removed request for
thePunderWoman
leonsenft
approved these changes
May 7, 2026
`parseErrors` in `FormField` always produced a new array on every recomputation, even when nothing actually changed. The `?? []` fallback created a new empty array whenever `parseErrorsSource` was undefined, and `.map()` also returned new object references each time.
Since computed signals use reference equality by default, those new arrays were treated as changed values. That caused unnecessary updates to propagate through `validationState.parseErrors` and the combined errors chain, triggering extra recomputations during change detection.
Fix this by adding `{equal: shallowArrayEquals}` to the `parseErrors` computed, matching the existing `errors` computed and the validation computeds in `field/validation.ts`.
This prevents empty arrays from triggering updates while still correctly propagating real parse-error changes.
arturovt
force-pushed
the
perf/forms-parseErrors-shallow-equal
branch
from
efb68dd to
0f168cf
Compare
arturovt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parseErrorsinFormFieldalways produced a new array on every recomputation, even when nothing actually changed. The?? []fallback created a new empty array wheneverparseErrorsSourcewas undefined, and.map()also returned new object references each time.Since computed signals use reference equality by default, those new arrays were treated as changed values. That caused unnecessary updates to propagate through
validationState.parseErrorsand the combined errors chain, triggering extra recomputations during change detection.Fix this by adding
{equal: shallowArrayEquals}to theparseErrorscomputed, matching the existingerrorscomputed and the validation computeds infield/validation.ts.This prevents empty arrays from triggering updates while still correctly propagating real parse-error changes.
Note: both old value and new value are
[].