fix(docs-infra): keep mobile nav open when closing the search dialog#68627
Open
erkamyaman wants to merge 1 commit intoangular:mainfrom
Open
fix(docs-infra): keep mobile nav open when closing the search dialog#68627erkamyaman wants to merge 1 commit intoangular:mainfrom
erkamyaman wants to merge 1 commit intoangular:mainfrom
Conversation
Backdrop clicks on the search dialog were also closing the open mobile nav drawers. Adds an id to `<dialog>` and references it from both navs' `docsClickOutsideIgnore` arrays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backdrop clicks on the search dialog were also closing the open mobile nav drawers. Adds an id to
<dialog>and references it from both navs'docsClickOutsideIgnorearrays.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
On mobile, clicking the search dialog backdrop also collapses the open primary and secondary nav drawers — neither nav's click-outside listener recognises the click target as sitting inside the dialog.
Screen.Recording.2026-05-08.at.00.59.02.mov
What is the new behavior?
Backdrop clicks close only the search dialog; the open mobile nav drawers stay open.
Screen.Recording.2026-05-08.at.01.00.22.mov
Does this PR introduce a breaking change?