Skip to content

fix(docs-infra): keep mobile nav open when closing the search dialog#68627

Open
erkamyaman wants to merge 1 commit intoangular:mainfrom
erkamyaman:fix-search-dialog-closes-nav-mobile
Open

fix(docs-infra): keep mobile nav open when closing the search dialog#68627
erkamyaman wants to merge 1 commit intoangular:mainfrom
erkamyaman:fix-search-dialog-closes-nav-mobile

Conversation

@erkamyaman
Copy link
Copy Markdown
Contributor

Backdrop clicks on the search dialog were also closing the open mobile nav drawers. Adds an id to <dialog> and references it from both navs' docsClickOutsideIgnore arrays.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

On mobile, clicking the search dialog backdrop also collapses the open primary and secondary nav drawers — neither nav's click-outside listener recognises the click target as sitting inside the dialog.

Screen.Recording.2026-05-08.at.00.59.02.mov

What is the new behavior?

Backdrop clicks close only the search dialog; the open mobile nav drawers stay open.

Screen.Recording.2026-05-08.at.01.00.22.mov

Does this PR introduce a breaking change?

  • Yes
  • No

Backdrop clicks on the search dialog were also closing the open mobile nav drawers. Adds an id to `<dialog>` and references it from both navs' `docsClickOutsideIgnore` arrays.
@pullapprove pullapprove Bot requested a review from MarkTechson May 7, 2026 22:02
@angular-robot angular-robot Bot added the area: docs-infra Angular.dev application and infrastructure label May 7, 2026
@ngbot ngbot Bot added this to the Backlog milestone May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docs-infra Angular.dev application and infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant