feat: add shell tool display mode preference#25029
Draft
DanielleMaywood wants to merge 1 commit intomainfrom
Draft
feat: add shell tool display mode preference#25029DanielleMaywood wants to merge 1 commit intomainfrom
DanielleMaywood wants to merge 1 commit intomainfrom
Conversation
Docs preview📖 View docs preview for |
DanielleMaywood
force-pushed
the
feat/shell-tool-display-mode
branch
from
1124851 to
9272f83
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
🤖 This PR was written by Coder Agent on behalf of Danielle Maywood
Stacked on #25027. Adds the
shell_tool_display_modeuser preference for Coder Agents shell tool calls (executeandprocess_output) while keeping the code-diff preference in the base PR.This remains a draft because the shell/execute/process output collapse UX is still iterative.
shell_tool_display_modeintentionally supports onlyauto,always_expanded, andalways_collapsed.previewremains a thinking-block-only mode.Changes
shell_tool_display_mode.ConversationTimelineandToolrenderers.ExecuteToolandProcessOutputToolinToolCollapsibleso they can start in auto, expanded, or collapsed states.Verification
make genmake test RUN=TestAgentDisplayModePreferences TEST_PACKAGES=./coderdmake test RUN=TestDBAuthzRecursive/GetUserShellToolDisplayMode TEST_PACKAGES=./coderd/database/dbauthzmake test RUN=TestDBAuthzRecursive/UpdateUserShellToolDisplayMode TEST_PACKAGES=./coderd/database/dbauthzmake test RUN=TestDBAuthzRecursive/GetUserCodeDiffDisplayMode TEST_PACKAGES=./coderd/database/dbauthzmake test RUN=TestDBAuthzRecursive/UpdateUserCodeDiffDisplayMode TEST_PACKAGES=./coderd/database/dbauthzcd site && pnpm test src/pages/AgentsPage/components/ChatElements/tools/displayMode.test.tscd site && CI=1 pnpm test:storybook src/pages/AgentsPage/components/ChatElements/tools/Tool.stories.tsx -t "Execute Success|Execute Always Collapsed|Process Output Always Collapsed|Write File Success|Write File Always Expanded|Edit Files Single Success|Edit Files Always Collapsed" --runcd site && CI=1 pnpm test:storybook src/pages/AgentsPage/components/ChatConversation/ConversationTimeline.stories.tsx -t "Tool Display Modes From Preferences" --runcd site && CI=1 pnpm test:storybook src/pages/AgentsPage/AgentSettingsGeneralPageView.stories.tsx -t "Renders Agent Display Mode Settings" --runcd site && pnpm checkmake fmtmake lintgit diff --checkpre-commitpassedImplementation plan / split context
The original implementation plan covered two preferences:
code_diff_display_modeforwrite_file,edit_files, and fallback inline diffs.shell_tool_display_modeforexecuteandprocess_output.The work was split into stacked draft PRs:
Both tool preferences use
auto,always_expanded, andalways_collapsed.autopreserves the previous per-tool default behavior.