Fix gradle deps conflict in integration_test/example#186095
Fix gradle deps conflict in integration_test/example#186095andywolff wants to merge 1 commit intoflutter:masterfrom
Conversation
github-actions
Bot
added
a: tests
andywolff
force-pushed
the
android_test_apk
branch
from
f67e3de to
3434681
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Android test dependencies in build.gradle.kts to use dynamic versions for androidx.test:runner and androidx.test.espresso:espresso-core. Feedback was provided suggesting that specific versions should be pinned instead of using dynamic ranges to ensure build determinism and reproducibility.
| androidTestImplementation("androidx.test:runner:1.2+") | ||
| androidTestImplementation("androidx.test.espresso:espresso-core:3.2+") |
There was a problem hiding this comment.
Using dynamic versions (e.g., 1.2+) in Gradle dependencies makes builds non-deterministic and can lead to unexpected breakages when new versions are released. While this change matches the parent directory's configuration to resolve conflicts, pinning both locations to a specific version is a more robust practice for ensuring build reproducibility.
…ions to match those in integration_test/android/build.gradle.kts, fixing a dep conflict
andywolff
force-pushed
the
android_test_apk
branch
from
2f52b10 to
e968497
Compare
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
1 participant
Update integration_test/example/android/app/build.gradle.kts dep versions to match those in integration_test/android/build.gradle.kts, fixing #186086
I'm told that we don't have specific policies around gradle dependency versions for example apps, so this PR updates it to match those elsewhere in the parent directory. I also update the example's project.lockfile using
./gradlew :generateLockfiles.There are no relevant tests for this example app which need an update.
Pre-launch Checklist
///).