Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

docs: update docstrings of DataFrame and related files#1092

Merged
tswast merged 10 commits intomainfrom
b296390934-docstring-type-annotation
Oct 24, 2024
Merged

docs: update docstrings of DataFrame and related files#1092
tswast merged 10 commits intomainfrom
b296390934-docstring-type-annotation

Conversation

@arwas11
Copy link
Copy Markdown
Contributor

@arwas11 arwas11 commented Oct 17, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #296390934 🦕

@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 17, 2024
@arwas11 arwas11 requested a review from tswast October 17, 2024 17:09
tswast
tswast reviewed Oct 17, 2024
View reviewed changes
Comment thread bigframes/dataframe.py Outdated
Comment thread third_party/bigframes_vendored/pandas/core/frame.py Outdated
Comment thread third_party/bigframes_vendored/pandas/core/generic.py Outdated
@arwas11 arwas11 requested a review from tswast October 21, 2024 16:16
@arwas11 arwas11 marked this pull request as ready for review October 22, 2024 14:51
@arwas11 arwas11 requested review from a team October 22, 2024 14:51
@arwas11 arwas11 added the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 22, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Oct 22, 2024
tswast
tswast reviewed Oct 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments. Otherwise, looking good. Thanks!

Comment thread bigframes/dataframe.py Outdated
Comment thread third_party/bigframes_vendored/pandas/core/frame.py Outdated
Comment thread third_party/bigframes_vendored/pandas/core/generic.py Outdated
Comment thread third_party/bigframes_vendored/pandas/core/generic.py Outdated
@arwas11 arwas11 requested a review from tswast October 23, 2024 15:55
tswast
tswast reviewed Oct 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my previous feedback. A few more nits.

Comment thread bigframes/dataframe.py Outdated
Comment thread third_party/bigframes_vendored/pandas/core/frame.py Outdated
Comment thread third_party/bigframes_vendored/pandas/core/frame.py Outdated
Comment thread third_party/bigframes_vendored/pandas/core/frame.py Outdated
Comment thread third_party/bigframes_vendored/pandas/core/generic.py Outdated
@tswast tswast merged commit 15e9fd5 into main Oct 24, 2024
@tswast tswast deleted the b296390934-docstring-type-annotation branch October 24, 2024 14:12
@release-please release-please Bot mentioned this pull request Oct 24, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tswast tswast tswast approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@GarrettWu GarrettWu

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arwas11 @tswast @GarrettWu