Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

docs: update GroupBy docstrings#1103

Merged
tswast merged 3 commits intomainfrom
b296390934-docstrings-type-annotation1
Oct 30, 2024
Merged

docs: update GroupBy docstrings#1103
tswast merged 3 commits intomainfrom
b296390934-docstrings-type-annotation1

Conversation

@arwas11
Copy link
Copy Markdown
Contributor

@arwas11 arwas11 commented Oct 22, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #296390934 🦕

@arwas11 arwas11 requested a review from tswast October 22, 2024 21:03
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Oct 22, 2024
@arwas11 arwas11 marked this pull request as ready for review October 28, 2024 21:36
@arwas11 arwas11 requested review from a team October 28, 2024 21:36
tswast
tswast approved these changes Oct 30, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@tswast tswast enabled auto-merge (squash) October 30, 2024 16:35
@tswast tswast merged commit 9867a78 into main Oct 30, 2024
@tswast tswast deleted the b296390934-docstrings-type-annotation1 branch October 30, 2024 16:58
@release-please release-please Bot mentioned this pull request Oct 30, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tswast tswast tswast approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mattyopl mattyopl

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arwas11 @tswast @mattyopl