Skip to content
This repository was archived by the owner on May 7, 2026. It is now read-only.

refactor: provide infrastructure for SQLGlot aggregations compiler#1926

Merged
chelsea-lin merged 3 commits intomainfrom
main_chelsealin_aggtests
Jul 22, 2025
Merged

refactor: provide infrastructure for SQLGlot aggregations compiler#1926
chelsea-lin merged 3 commits intomainfrom
main_chelsealin_aggtests

Conversation

@chelsea-lin
Copy link
Copy Markdown
Contributor

Fixes internal issue 431277229🦕

@chelsea-lin chelsea-lin requested a review from sycai July 21, 2025 22:56
@product-auto-label product-auto-label Bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jul 21, 2025
@chelsea-lin chelsea-lin marked this pull request as ready for review July 21, 2025 22:57
@chelsea-lin chelsea-lin requested review from a team July 21, 2025 22:57
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_aggtests branch from e7a76f3 to 49263e8 Compare July 21, 2025 23:00
@chelsea-lin chelsea-lin force-pushed the main_chelsealin_aggtests branch from 49263e8 to b771319 Compare July 21, 2025 23:01
sycai
sycai previously approved these changes Jul 21, 2025
Comment thread tests/unit/core/compile/sqlglot/aggregations/test_op_registration.py Outdated
Comment thread tests/unit/core/compile/sqlglot/aggregations/test_unary_compiler.py
Comment thread tests/unit/core/compile/sqlglot/aggregations/test_unary_compiler.py
@chelsea-lin
Copy link
Copy Markdown
Contributor Author

The "test_create_job_configs_labels_log_adaptor_call_method_under_length_limit" failures does not look like to relate this change. Hence, create #1927 to fix this flaky test.

@chelsea-lin chelsea-lin merged commit c57f04e into main Jul 22, 2025
23 of 25 checks passed
@chelsea-lin chelsea-lin deleted the main_chelsealin_aggtests branch July 22, 2025 19:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants