This repository was archived by the owner on May 7, 2026. It is now read-only.
chore: remove to_pandas_dtypes_overrides dead code#404
Merged
gcf-merge-on-green[bot] merged 17 commits intogoogleapis:mainfrom Mar 13, 2024
Merged
chore: remove to_pandas_dtypes_overrides dead code#404gcf-merge-on-green[bot] merged 17 commits intogoogleapis:mainfrom
to_pandas_dtypes_overrides dead code#404gcf-merge-on-green[bot] merged 17 commits intogoogleapis:mainfrom
Conversation
…uery-dataframes into salem_timeseriessample
…es into salem_timeseriessample
product-auto-label
Bot
added
size: m
tswast
suggested changes
Mar 4, 2024
| @@ -0,0 +1,82 @@ | |||
| # Copyright 2023 Google LLC | |||
Contributor
There was a problem hiding this comment.
This file shouldn't be included in this PR.
| # better if we called `to_arrow()` and converted to a pandas | ||
| # DataFrame ourselves from that. | ||
| dtypes[field.name] = pd.ArrowDtype( | ||
| gcb3p_pandas_helpers.bq_to_arrow_data_type(field) |
Contributor
There was a problem hiding this comment.
I believe this import is no longer used.
See lint error https://github.com/googleapis/python-bigquery-dataframes/actions/runs/8144793137
product-auto-label
Bot
added
size: s
…ataframes into SalemChore
product-auto-label
Bot
added
size: xl
tswast
changed the title
to_pandas_dtypes_overrides dead codeto_pandas_dtypes_overrides dead code
tswast
suggested changes
Mar 4, 2024
| @@ -1,1281 +0,0 @@ | |||
| # Copyright 2023 Google LLC | |||
product-auto-label
Bot
added
size: u
This reverts commit 49f3a7b.
product-auto-label
Bot
added
size: s
tswast
added
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
tswast
added
owlbot:run
gcf-owl-bot
Bot
removed
the
owlbot:run
tswast
approved these changes
Mar 13, 2024
tswast
added
the
automerge
gcf-merge-on-green
Bot
removed
the
automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕