Use super() instead of manually fetching supermethods for parasite axes.#11678
Merged
jklymak merged 2 commits intomatplotlib:masterfrom Jul 17, 2018
Merged
Use super() instead of manually fetching supermethods for parasite axes.#11678jklymak merged 2 commits intomatplotlib:masterfrom
jklymak merged 2 commits intomatplotlib:masterfrom
Conversation
(This manual fetching was previously done in _get_base_axes_attr.)
jklymak
approved these changes
Jul 17, 2018
timhoffm
approved these changes
Jul 17, 2018
Member
timhoffm
left a comment
timhoffm
left a comment
There was a problem hiding this comment.
Good, apart from the "do not use" comment that should be clarified.
| return ax2 | ||
|
|
||
| def _get_legend_handles(self, legend_handler_map=None): | ||
| # don't use this! |
Member
There was a problem hiding this comment.
@jklymak You put this coment in last year. Why? Should it be removed?
Member
There was a problem hiding this comment.
#9324 (comment) I think the whole method should be removed, but maybe I'll put that in as a separate PR and not burden @anntzer with sorting out this stuff as part of an otherwise straightforward PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This manual fetching was previously done in _get_base_axes_attr.
Second commit style-cleans the module.
PR Checklist