Skip to content

Set facecolor of FilledArrow axisline style and fix tight layout#24085

Merged
ksunden merged 4 commits intomatplotlib:mainfrom
oscargus:testaxislinestyle
Jan 7, 2023
Merged

Set facecolor of FilledArrow axisline style and fix tight layout#24085
ksunden merged 4 commits intomatplotlib:mainfrom
oscargus:testaxislinestyle

Conversation

@oscargus
Copy link
Copy Markdown
Member

@oscargus oscargus commented Oct 3, 2022 •
edited
Loading

PR Summary

Original purpose was to test axisline style, but as part of that:

Add support for providing facecolor to a FilledArrow, defaulting to the same color as the axes edgecolor.

Make tight (and other) layouts work for axislines by fixing get_window_extents, thanks to @leejjoon

Closes #7617 (fixed elsewhere, but adding test here).

PR Checklist

Tests and Styling

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (install flake8-docstrings and run flake8 --docstring-convention=all).

Documentation

  • New features are documented, with examples if plot related.
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).

@oscargus oscargus added this to the v3.7.0 milestone Oct 3, 2022
@oscargus oscargus force-pushed the testaxislinestyle branch 3 times, most recently from bdcafbc to 0d5f40a Compare October 4, 2022 06:33
QuLogic
QuLogic reviewed Oct 4, 2022
View reviewed changes
Comment thread lib/mpl_toolkits/tests/test_axisartist_axislines.py
@oscargus oscargus force-pushed the testaxislinestyle branch 2 times, most recently from 9140a3d to e06bfc6 Compare October 4, 2022 08:08
@oscargus oscargus marked this pull request as draft October 4, 2022 08:42
@oscargus