Skip to content

Fix some font-related issues#31634

Merged
ksunden merged 4 commits intomatplotlib:mainfrom
QuLogic:fix-font-typehints
May 8, 2026
Merged

Fix some font-related issues#31634
ksunden merged 4 commits intomatplotlib:mainfrom
QuLogic:fix-font-typehints

Conversation

@QuLogic
Copy link
Copy Markdown
Member

@QuLogic QuLogic commented May 8, 2026

PR summary

Mostly, I went through some type hints warnings and found things in the new font implementations that were real bugs. See the commits for additional details.

AI Disclosure

None

PR checklist

QuLogic added 4 commits May 8, 2026 02:12
- Some places take/emit a `FontPath` and not a `str` any more.
- The module-level `findfont` is a copy of an instance method, so it
  should match that as well.
- Also add some private things, because they help find some additional
  bugs, and at least `_find_fonts_by_props` is possibly going to be
  public later.
It wasn't updated to handle the change to `VectorParse` in matplotlib#30335.
The method was removed in matplotlib#29939, but this call site was forgotten.
@ksunden ksunden merged commit 539085d into matplotlib:main May 8, 2026
38 of 41 checks passed
@QuLogic QuLogic deleted the fix-font-typehints branch May 8, 2026 19:13
ksunden added a commit that referenced this pull request May 8, 2026
ksunden added a commit that referenced this pull request May 8, 2026
…634-on-v3.11.x

Backport PR #31634 on branch v3.11.x (Fix some font-related issues)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants