Skip to content

test: add unit tests for pet-venv crate (Fixes #389)#444

Open
karthiknadig wants to merge 1 commit into
mainfrom
test/issue-389-venv
Open

test: add unit tests for pet-venv crate (Fixes #389)#444
karthiknadig wants to merge 1 commit into
mainfrom
test/issue-389-venv

Conversation

@karthiknadig
Copy link
Copy Markdown
Member

@karthiknadig karthiknadig commented Apr 22, 2026

Add 4 new unit tests to pet-venv (17 total, up from 13):

  • try_from without prefix derives from executable path
  • try_from uses version from PythonEnv when provided
  • try_environment_from_venv_dir with no prompt in pyvenv.cfg
  • is_venv detects pyvenv.cfg via executable parent

Fixes #389

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026 •
edited
Loading

Test Coverage Report (Linux)

Metric Value
Current Coverage 75.7%
Base Branch Coverage 75.6%
Delta .1% ✅

Coverage increased! Great work!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026 •
edited
Loading

Performance Report (Linux) ➖

Metric PR (P50) PR (P95) Baseline (P50) Delta Change
Server Startup 1ms 1ms 0ms 1ms N/A%
Full Refresh 60ms 217ms 53ms 7ms 10.0%

Results based on 10 iterations. P50 = median, P95 = 95th percentile.

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026 •
edited
Loading

Performance Report (macOS)

Metric PR (P50) PR (P95) Baseline (P50) Delta
Server Startup 63ms 622ms 85ms -22ms
Full Refresh 136ms 31749ms 175ms -39ms

Results based on 10 iterations. P50 = median, P95 = 95th percentile.

Legend
  • 🚀 Significant speedup (>100ms faster)
  • ✅ Faster than baseline
  • ➖ No significant change
  • 🔺 Slower than baseline (>100ms)
  • ⚠️ Significant slowdown (>500ms)