doc: clarify SEA platform support excludes darwin-x64#63181
Open
mokashang wants to merge 1 commit intonodejs:mainfrom
Open
doc: clarify SEA platform support excludes darwin-x64#63181mokashang wants to merge 1 commit intonodejs:mainfrom
mokashang wants to merge 1 commit intonodejs:mainfrom
Conversation
The Platform support section of the single-executable-applications doc listed `macOS` without qualifying which architecture is supported. SEA on x64 macOS is not supported and is skipped in CI; only arm64 macOS is exercised. Refs: nodejs#62893 Signed-off-by: mokashang <64570909+mokashang@users.noreply.github.com>
Collaborator
|
Review requested:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Platform support" section of
doc/api/single-executable-applications.mdpreviously listedmacOSwithout qualifying which architecture is supported. Per a maintainer comment on #62893, SEA on x64 macOS is not supported and is skipped in CI; only arm64 macOS is exercised. This updates the doc to clarify that.Refs: #62893