Skip to content

gh-106320: Remove private _PyLong converter functions#108499

Merged
vstinner merged 3 commits into
python:mainfrom
vstinner:remove_long_converter
Aug 26, 2023
Merged

gh-106320: Remove private _PyLong converter functions#108499
vstinner merged 3 commits into
python:mainfrom
vstinner:remove_long_converter

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Aug 25, 2023 •
edited by bedevere-bot
Loading

Move private functions to the internal C API (pycore_traceback.h):

Argument Clinic now emits #include "pycore_long.h" when using these functions.

@bedevere-bot bedevere-bot mentioned this pull request Aug 25, 2023
Closed
@vstinner vstinner mentioned this pull request Aug 25, 2023
Merged
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Aug 25, 2023

@erlend-aasland @AlexWaygood: This change #include "pycore_long.h" to Modules/clinic/_testclinic_depr.c.h while this file doesn't use it. This file looks special, I didn't know this directive in Modules/_testclinic.c:

/*[clinic input]
output push
destination deprstar new file '{dirname}/clinic/_testclinic_depr.c.h'
output everything deprstar
#output methoddef_ifndef buffer 1
output docstring_prototype suppress
output parser_prototype suppress
output impl_definition block
[clinic start generated code]*/
/*[clinic end generated code: output=da39a3ee5e6b4b0d input=32116eac48a42d34]*/

Adding an unused #include is not a bug, but it's not optimum :-) I propose to fix it later to unblock my removal change.

@vstinner
pythongh-106320: Remove private _PyLong converter functions
5f2faf4 
Move private functions to the internal C API (pycore_traceback.h):

Argument Clinic now emits #include "pycore_long.h" when using these
functions.
@vstinner
Fix overlapped.c build on Windows
db05a2a
@vstinner
Fix make check-c-globals
d0b56a7
@vstinner vstinner force-pushed the remove_long_converter branch from 8ec187a to d0b56a7 Compare August 25, 2023 23:36
@vstinner vstinner mentioned this pull request Aug 25, 2023
Merged
@vstinner vstinner merged commit 713afb8 into python:main Aug 26, 2023
@vstinner vstinner deleted the remove_long_converter branch August 26, 2023 00:24
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Aug 26, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable LTO + PGO 3.x has failed when building commit 713afb8.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/524/builds/4310) and take a look at the build logs.
  4. Check if the failure is related to this commit (713afb8) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/524/builds/4310

Failed tests:

  • test.test_concurrent_futures.test_shutdown

Failed subtests:

  • test_interpreter_shutdown - test.test_concurrent_futures.test_shutdown.ProcessPoolForkserverProcessPoolShutdownTest.test_interpreter_shutdown

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

447 tests OK.

10 slowest tests:

  • test.test_concurrent_futures.test_wait: 1 min 10 sec
  • test.test_multiprocessing_spawn.test_processes: 1 min 8 sec
  • test_signal: 1 min 2 sec
  • test_socket: 46.8 sec
  • test_io: 39.2 sec
  • test.test_multiprocessing_forkserver.test_processes: 38.9 sec
  • test_subprocess: 34.4 sec
  • test_imaplib: 30.9 sec
  • test.test_asyncio.test_tasks: 30.4 sec
  • test_unparse: 30.2 sec

1 test failed:
test.test_concurrent_futures.test_shutdown

15 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_gdb
test_ioctl test_kqueue test_launcher test_startfile test_tkinter
test_ttk test_winconsoleio test_winreg test_winsound test_wmi
test_zipfile64

1 re-run test:
test.test_concurrent_futures.test_shutdown

Total duration: 1 min 37 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/test/test_concurrent_futures/test_shutdown.py", line 49, in test_interpreter_shutdown
    self.assertFalse(err)
AssertionError: b'Exception in thread Thread-1:\nTraceback (most recent call last):\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/threading.py", line 1059, in _bootstrap_inner\n    self.run()\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/concurrent/futures/process.py", line 339, in run\n    self.add_call_item_to_queue()\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/concurrent/futures/process.py", line 394, in add_call_item_to_queue\n    self.call_queue.put(_CallItem(work_id,\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/multiprocessing/queues.py", line 94, in put\n    self._start_thread()\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/multiprocessing/queues.py", line 177, in _start_thread\n    self._thread.start()\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/threading.py", line 978, in start\n    _start_new_thread(self._bootstrap, ())\nRuntimeError: can\'t create new thread at interpreter shutdown\nTraceback (most recent call last):\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/multiprocessing/forkserver.py", line 274, in main\n    code = _serve_one(child_r, fds,\n           ^^^^^^^^^^^^^^^^^^^^^^^^\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/multiprocessing/forkserver.py", line 313, in _serve_one\n    code = spawn._main(child_r, parent_sentinel)\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/multiprocessing/spawn.py", line 132, in _main\n    self = reduction.pickle.load(from_parent)\n           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.lto-pgo/build/Lib/multiprocessing/synchronize.py", line 115, in __setstate__\n    self._semlock = _multiprocessing.SemLock._rebuild(*state)\n                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nFileNotFoundError: [Errno 2] No such file or directory\n' is not false