Skip to content

bpo-29587: Remove the exc_value NULL check in _gen_throw()#19877

Merged
cjerdonek merged 2 commits intopython:masterfrom
cjerdonek:issue-29587-allow-null-values
May 3, 2020
Merged

bpo-29587: Remove the exc_value NULL check in _gen_throw()#19877
cjerdonek merged 2 commits intopython:masterfrom
cjerdonek:issue-29587-allow-null-values

Conversation

@cjerdonek
Copy link
Copy Markdown
Member

@cjerdonek cjerdonek commented May 3, 2020 •
edited
Loading

This is another follow-up to PR #19823, removing the check that exc_value isn't NULL prior to calling _PyErr_ChainExceptions(). This makes it so that exception chaining can occur in more cases.

https://bugs.python.org/issue29587

@cjerdonek cjerdonek requested a review from 1st1 as a code owner May 3, 2020 04:28
gvanrossum
gvanrossum approved these changes May 3, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck!

@cjerdonek
Copy link
Copy Markdown
Member Author

cjerdonek commented May 3, 2020

Thanks! :) I'll be posting a comment on the issue with what I found..