Skip to content

bpo-38787: update docs of structures.rst and code style of _testmultiphase.c#19980

Merged
vstinner merged 1 commit into
python:masterfrom
shihai1991:bpo_38787
May 7, 2020
Merged

bpo-38787: update docs of structures.rst and code style of _testmultiphase.c#19980
vstinner merged 1 commit into
python:masterfrom
shihai1991:bpo_38787

Conversation

@shihai1991
Copy link
Copy Markdown
Member

@shihai1991 shihai1991 commented May 7, 2020 •
edited by bedevere-bot
Loading

corona10
corona10 reviewed May 7, 2020
View reviewed changes
Comment thread Modules/_testmultiphase.c
};

static PyModuleDef def_meth_state_access = {
PyModuleDef_HEAD_INIT, /* m_base */
Copy link
Copy Markdown
Member

@corona10 corona10 May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't usually accept the style changing PR.

Copy link
Copy Markdown
Member

@vstinner vstinner May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked for this PR on purpose :-) Read comments starting at: #19936 (review)

Copy link
Copy Markdown
Member

@corona10 corona10 May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see :)

corona10
corona10 requested changes May 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented May 7, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

vstinner
vstinner approved these changes May 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread Modules/_testmultiphase.c
};

static PyModuleDef def_meth_state_access = {
PyModuleDef_HEAD_INIT, /* m_base */
Copy link
Copy Markdown
Member

@vstinner vstinner May 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked for this PR on purpose :-) Read comments starting at: #19936 (review)

corona10
corona10 approved these changes May 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vstinner vstinner merged commit c068b53 into python:master May 7, 2020
@vstinner
Copy link
Copy Markdown
Member

vstinner commented May 7, 2020

Thanks @shihai1991, merged.

@shihai1991
Copy link
Copy Markdown
Member