gh-92841: Fix asyncio's RuntimeError: Event loop is closed#92842
Merged
zooba merged 2 commits intopython:mainfrom May 17, 2022
Merged
gh-92841: Fix asyncio's RuntimeError: Event loop is closed#92842zooba merged 2 commits intopython:mainfrom
zooba merged 2 commits intopython:mainfrom
Conversation
Member
Author
|
Note that the NEWS entry uses classDiagram
_ProactorBasePipeTransport <|-- _ProactorReadPipeTransport
_ProactorBasePipeTransport <|-- _ProactorBaseWritePipeTransport
_ProactorBasePipeTransport <|-- _ProactorDatagramTransport
_ProactorReadPipeTransport <|-- _ProactorDuplexPipeTransport
_ProactorBaseWritePipeTransport <|-- _ProactorDuplexPipeTransport
_ProactorReadPipeTransport <|-- _ProactorSocketTransport
_ProactorBaseWritePipeTransport <|-- _ProactorSocketTransport
|
zooba
reviewed
May 17, 2022
…x107.rst Co-authored-by: Steve Dower <steve.dower@microsoft.com>
Contributor
|
Thanks @arhadthedev for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10. |
Contributor
|
Thanks @arhadthedev for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 17, 2022
…honGH-92842) (cherry picked from commit 33880b4) Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
|
GH-92904 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 17, 2022
…honGH-92842) (cherry picked from commit 33880b4) Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
|
GH-92905 is a backport of this pull request to the 3.11 branch. |
miss-islington
added a commit
that referenced
this pull request
May 17, 2022
ambv
pushed a commit
that referenced
this pull request
Jun 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
asyncio.selector_events._SelectorTransportandasyncio.proactor_events._ProactorBasePipeTransportcheck if an associated socket is left unclosed and emit a warning on a positive answer.However, further behavior differs. While
_SelectorTransportcloses the socket:the
_ProactorBasePipeTransportattempts to close itself leaving the socked leaked:It looks like there was no plan to close the transport itself causing
<already closed parent loop>.call_soon().The deleters were introduced by 978a9af with no explanatory comment about the implementation difference.
Fixes (no autoclose) gh-92841, gh-91233, and gh-83413. Probably fixes (no autoclose) gh-81562.