Skip to content

GH-98219: reduce sleep time in asyncio subprocess test#99464

Merged
gvanrossum merged 2 commits intopython:mainfrom
kumaraditya303:reduce-sleep
Nov 14, 2022
Merged

GH-98219: reduce sleep time in asyncio subprocess test#99464
gvanrossum merged 2 commits intopython:mainfrom
kumaraditya303:reduce-sleep

Conversation

@kumaraditya303
Copy link
Copy Markdown
Contributor

@kumaraditya303 kumaraditya303 commented Nov 14, 2022 •
edited
Loading

Instead of 100000000, 2 is used so that the test still works but the process completes after 2 sec and hopefully avoid permission errors.

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Nov 14, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 14, 2022
Closed
@kumaraditya303
Copy link
Copy Markdown
Contributor Author

kumaraditya303 commented Nov 14, 2022 •
edited
Loading

FWIW this seems to only happen on very slow machines like Github Actions with Windows 10. I have tried to reproduce this on Windows 11 but no luck.

@kumaraditya303
Copy link
Copy Markdown
Contributor Author

kumaraditya303 commented Nov 14, 2022

Windows tests passed, triggering bots again to check again that it works. For reference previous run https://github.com/python/cpython/actions/runs/3460146711/jobs/5776365470

@gvanrossum gvanrossum merged commit 619cadc into python:main Nov 14, 2022
@gvanrossum
Copy link
Copy Markdown
Member

gvanrossum commented Nov 14, 2022

Should this be backported to 3.11?

@kumaraditya303 kumaraditya303 deleted the reduce-sleep branch November 15, 2022 11:00
@kumaraditya303 kumaraditya303 added the needs backport to 3.11 only security fixes label Nov 15, 2022
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Nov 15, 2022