Fix output config option in mypy.ini#21416
Open
mitre88 wants to merge 1 commit intopython:masterfrom
Open
Conversation
The config parser was skipping options whose default value is None (e.g. 'output'), even when the attribute exists on the Options class. This was due to the condition 'dv is None' being used to skip unknown options, but some valid options intentionally have None defaults. The fix changes the condition to skip only options that don't exist on the template Options object (using hasattr), allowing options like 'output' to be set in config files. Fixes python#21376
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Collaborator
|
Please add a test. I notice the diff is quite different than #21398 so I'm not sure what's going on here :/ |
A5rocks
reviewed
May 7, 2026
| else: | ||
| dv = getattr(template, options_key, None) | ||
| if dv is None: | ||
| if dv is None and not hasattr(template, options_key): |
Collaborator
There was a problem hiding this comment.
Suggested change
| if dv is None and not hasattr(template, options_key): | |
| if not hasattr(template, options_key): |
I feel like this is simpler?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config parser was skipping options whose default value is None (e.g. 'output'), even when the attribute exists on the Options class.
This was due to the condition 'dv is None' being used to skip unknown options, but some valid options intentionally have None defaults.
The fix changes the condition to skip only options that don't exist on the template Options object (using hasattr), allowing options like 'output' to be set in config files.
Fixes #21376