The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Apr 24, 2026 9:42pm

PR Summary

Low Risk
Low risk: a small tracing/observability tweak that only changes how terminal SSE completion is detected (counts error as terminal) and doesn’t affect request/stream control flow.

Overview
Updates stampSseReadLoopSpan to treat SSE error events as terminal alongside complete, so copilot.sse.terminal_event_seen/copilot.sse.terminal_event_missing (and related dashboard signals) no longer flag streams that ended with an error event as “missing terminal”.

Adjusts the inline documentation to reflect the new terminal event definition (complete or error).

^{Reviewed by Cursor Bugbot for commit 4824ea3. Configure here.}

Greptile Summary

This PR fixes a false-positive in the terminal_event_missing OTel span attribute by recognising SSE error events as terminal events alongside complete events. Previously, a stream that ended with an error event would still set terminalEventMissing = true (because only complete counted), even though handleErrorEvent correctly sets context.streamComplete = true and increments counters.eventsByType.error.

Confidence Score: 5/5

This PR is safe to merge — the one-line change is logically correct and matches the existing handler contract.

The fix is minimal and provably correct: handleErrorEvent already sets context.streamComplete = true and counters.eventsByType.error is already tracked in the counters initialiser, so extending the terminalEventSeen guard to include error events eliminates a guaranteed false-positive in the dashboard alert without any side effects on span status or close-reason logic. No P0/P1 issues found.

No files require special attention.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[SSE Read Loop ends] --> B{context.streamComplete?}
    B -- No --> C[Log error: no terminal event\nendedOn = ClosedNoTerminal\nthrow CopilotBackendError]
    B -- Yes --> D[stampSseReadLoopSpan called]
    D --> E{counters.eventsByType.complete > 0\nOR counters.eventsByType.error > 0}
    E -- Yes --> F[terminalEventSeen = true]
    E -- No --> G[terminalEventSeen = false]
    F --> H{opts.expectedTerminal?}
    G --> H
    H -- Yes + terminalEventSeen=false --> I[terminalEventMissing = true\nSpan status → ERROR]
    H -- No or terminalEventSeen=true --> J[terminalEventMissing = false\nSpan status → UNSET]
    style I fill:#f88,stroke:#d00
    style J fill:#8f8,stroke:#080

_{Reviews (1): Last reviewed commit: "improvement(mothership): treat error as ..." | Re-trigger Greptile}