Skip to content

fix(knowledge): revert column width multipliers that misaligned Name header#4427

Merged
waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1/kb-name-align
May 4, 2026
Merged

fix(knowledge): revert column width multipliers that misaligned Name header#4427
waleedlatif1 merged 1 commit intostagingfrom
waleedlatif1/kb-name-align

Conversation

@waleedlatif1
Copy link
Copy Markdown
Collaborator

Summary

  • Revert widthMultiplier values on DOCUMENT_COLUMNS in the KB documents page
  • The multipliers shrunk numeric/badge columns, but the slack flowed into the Name column (table-fixed + w-full), making the Name header appear visually offset from the data on KB while other resource pages stayed flush left
  • Tighter numeric columns can come back later via a proper layout primitive (trailing spacer or fractional widths)

Type of Change

  • Bug fix

Testing

Tested manually on the KB documents page — Name column now matches Files / Tables / Scheduled Tasks layout.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link
Copy Markdown

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped May 4, 2026 5:14pm

Request Review

@cursor
Copy link
Copy Markdown

cursor Bot commented May 4, 2026

PR Summary

Low Risk
Low risk UI-only change that adjusts column sizing on the Knowledge Base documents table; no data flow or behavior changes.

Overview
Fixes a layout regression on the Knowledge Base documents list by removing the custom widthMultiplier values from DOCUMENT_COLUMNS in knowledge/[id]/base.tsx.

This restores default column widths so the Name header aligns with row content rather than absorbing leftover table width.

Reviewed by Cursor Bugbot for commit b23aa62. Configure here.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 4, 2026

Greptile Summary

This PR reverts widthMultiplier values from the DOCUMENT_COLUMNS constant in the KB documents page. The multipliers were shrinking numeric/badge columns, and under Tailwind's table-fixed + w-full layout the freed space flowed into the Name column, visually offsetting its header relative to the data rows.

Confidence Score: 5/5

Safe to merge — a one-property revert across five column definitions with no logic changes.

The diff is a targeted, mechanical revert of five widthMultiplier values. No logic, data handling, or API contracts are touched; the only effect is restoring default equal-width column sizing.

No files require special attention.

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/knowledge/[id]/base.tsx Removes widthMultiplier from 5 columns in DOCUMENT_COLUMNS, reverting a layout change that caused the Name column header to appear visually offset under table-fixed + w-full.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[DOCUMENT_COLUMNS config] --> B{widthMultiplier set?}
    B -- "Yes (before PR)" --> C[Narrower size/tokens/chunks/uploaded/status columns]
    C --> D[Excess width absorbed by Name column]
    D --> E[Name header visually offset from data]
    B -- "No (after PR)" --> F[Equal default column widths]
    F --> G[Name header aligned flush-left like other resource pages]
Loading

Reviews (1): Last reviewed commit: "fix(knowledge): revert column width mult..." | Re-trigger Greptile

@waleedlatif1 waleedlatif1 merged commit af8dfbd into staging May 4, 2026
14 checks passed
@waleedlatif1 waleedlatif1 deleted the waleedlatif1/kb-name-align branch May 4, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant