fix(executor): strip childTraceSpans from block state before LLM tool calls#4428
fix(executor): strip childTraceSpans from block state before LLM tool calls#4428waleedlatif1 merged 2 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview On error paths, stops adding Reviewed by Cursor Bugbot for commit 293c1f9. Configure here. |
Greptile SummaryThis fix strips Confidence Score: 5/5Safe to merge — the core state/LLM leakage is correctly fixed with no new issues introduced. The change is minimal and targeted. No files require special attention; the single changed file is well-contained. Important Files Changed
Sequence DiagramsequenceDiagram
participant Handler as Block Handler
participant BE as BlockExecutor
participant State as BlockStateWriter
participant Log as blockLog (Logs UI)
participant LLM as LLM Tool Context
Handler->>BE: returns normalizedOutput (with childTraceSpans)
BE->>Log: blockLog.output = filterOutputForLog(normalizedOutput)
BE->>BE: destructure → outputForState (childTraceSpans stripped)
BE->>State: setBlockOutput(outputForState)
BE->>LLM: return outputForState (no childTraceSpans)
Note over State,LLM: Traces never reach LLM tool result context
Reviews (2): Last reviewed commit: "fix(executor): return stripped output so..." | Re-trigger Greptile |
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 293c1f9. Configure here.
Summary
childTraceSpans) was being stored in execution state alongside the actual outputchildTraceSpansfrom the output beforesetBlockOutputon the success path; never put it inerrorOutputon the failure path — it stays inblockLogonly, which is where the Logs UI reads it fromType of Change
Testing
Tested manually
Checklist