Page MenuHomePhabricator

DLynch (David Lynch)
Senior Software Engineer

Projects (21)

Today

  • No visible events.

Tomorrow

  • No visible events.

Monday

  • No visible events.

User Details

User Since
Oct 1 2015, 7:50 PM (556 w, 1 d)
Availability
Available
IRC Nick
Kemayo
LDAP User
DLynch
MediaWiki User
DLynch (WMF) [ Global Accounts ]

Disclaimer: I work for or provide services to the Wikimedia Foundation. However, the Foundation does not vet all my activity, so edits, statements, or other contributions made by this account may not reflect the views of the Foundation.

Recent Activity

Yesterday

DLynch added a comment to T427626: Provide read access to template-generated categories in VE document model.

Here's an example of a template that adds a hidden category:

<link rel="mw:PageProp/Category" href="./Category:All_articles_with_unsourced_statements" about="#mwt5" typeof="mw:Transclusion" data-mw='{"parts":[{"template":{"target":{"wt":"Citation needed","href":"./Template:Citation_needed"},"params":{"date":{"wt":"January 2026"},"reason":{"wt":"There is conflicting information about when this album was released, as sources such as Amazon list the release date as 2001 instead of 2000. If one has a reliable source per WP:RSPS that says 2000, please cite it."}},"i":0}}]}' id="mwDQ"/><link rel="mw:PageProp/Category" href="./Category:Articles_with_unsourced_statements_from_January_2026" about="#mwt5"/><sup class="noprint Inline-Template Template-Fact" style="white-space:nowrap;" about="#mwt5" id="mwDg"><span typeof="mw:Entity">[</span><i><a rel="mw:WikiLink" href="./Wikipedia:Citation_needed" title="Wikipedia:Citation needed"><span title="There is conflicting information about when this album was released, as sources such as Amazon list the release date as 2001 instead of 2000. If one has a reliable source per WP:RSPS that says 2000, please cite it. (January 2026)">citation needed</span></a></i><span typeof="mw:Entity">]</span></sup>
Fri, May 29, 4:28 PM · VisualEditor, EditCheck
DLynch added a comment to T427520: Provide access to add a reference from the Citation Needed template in more languages.

One thing we could do is improve the documentation for this. I'm fairly sure this isn't highlighted anywhere as something a community might want to do.

Fri, May 29, 6:58 AM · VisualEditor
DLynch added a comment to T427594: Ctrl+Shift+Space inserts links in VisualEditor.

I cannot reproduce this on a mac (where it's option-shift-space):

CleanShot 2026-05-29 at 08.37.02@2x.png (588×866 px, 133 KB)

Fri, May 29, 6:38 AM · VisualEditor, VisualEditor-ContentEditable
DLynch added a comment to T426249: iOS Safari unable to load a Village Pump page when clicking on link to a sub-thread.

One more reproduction note: I cannot reproduce this when I have JS disabled.

Fri, May 29, 6:04 AM · JavaScript, MinervaNeue, Parsoid, Browser-Support-Apple-Safari

Thu, May 28

DLynch added a comment to T426249: iOS Safari unable to load a Village Pump page when clicking on link to a sub-thread.

Might be worth leaving the MinervaNeue tag on, just because it's significantly easier to trigger there, so there may be some relation.

Thu, May 28, 9:30 PM · JavaScript, MinervaNeue, Parsoid, Browser-Support-Apple-Safari
DLynch added a comment to T426249: iOS Safari unable to load a Village Pump page when clicking on link to a sub-thread.

@gh87 https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(WMF)?useformat=desktop&useparsoid=1&useskin=vector2022#Survey should get you that. It could be somewhat device-dependent, since the apparent error is RAM-exhaustion -- I'm testing it on an iPhone 17 pro, meaning there's 12GB of RAM.

Thu, May 28, 8:00 PM · JavaScript, MinervaNeue, Parsoid, Browser-Support-Apple-Safari
DLynch added a comment to T426249: iOS Safari unable to load a Village Pump page when clicking on link to a sub-thread.
Thu, May 28, 5:11 PM · JavaScript, MinervaNeue, Parsoid, Browser-Support-Apple-Safari
DLynch added a comment to T322218: Create API to allow retrieving detailed information about Thanks log items for my own user account.

Note that this does expose something currently sort-of private, which is exactly what content was thanked. The user was told this when the notification of the thanks arrived, but if they cleared that notification then it was no longer available to them.

Thu, May 28, 1:17 PM · Connection-Team, Privacy Engineering, Thanks
DLynch closed T427458: ext.testKitchen not loaded by ext.wikimediaEvents module causing errors as Resolved.
Thu, May 28, 12:33 PM · Test Kitchen (Experiment Platform Sprint 24), MediaWiki-extensions-WikimediaEvents
DLynch added a comment to T427102: Moving [[WP:VPWMF#WMF Community Tech team has been disbanded, engineers laid off]] to subpage(s).

Follow-up: I have done some DiscussionTools performance work on the above-mentioned ticket.

Thu, May 28, 12:25 PM · Performance Issue, DiscussionTools
DLynch added a comment to T416247: Request for investigating performance issues in long talkpages.

^ those patches take a local clone I made of the currently very-busy Village_Pump_(WMF), and reduce the time-cost of these areas of DiscussionTools during the initial page load from 176ms to 25ms. (On my high-spec macbook, so we can expect that to be more significant for many users.)

Thu, May 28, 12:25 PM · Patch-For-Review, Content-Transform-Team, Accessibility, DiscussionTools, Editing-team (Planning)
DLynch added a comment to T426249: iOS Safari unable to load a Village Pump page when clicking on link to a sub-thread.

Did you try useformat=mobile&useskin=monobook ? That would help eliminate whether Minerva has anything to do with this.

Thu, May 28, 5:43 AM · JavaScript, MinervaNeue, Parsoid, Browser-Support-Apple-Safari

Wed, May 27

DLynch added a comment to T425983: Allow setting user account limits for checks in suggestion mode.

As a variant of 1/2, we could make the existing showAsCheck and showAsSuggestion keys accept a config-object as well as just a boolean. We've already got precedent of doing nested config checks via textmatch rules, so a similar system could be used here. Check the top-level config, and then check whichever of the sub-configs are provided.

Wed, May 27, 8:58 AM · VisualEditor Suggestion Mode, OKR-Work, EditCheck, Editing-team (Editing-current-Q4-11May-22May-2026)
DLynch added a comment to T426249: iOS Safari unable to load a Village Pump page when clicking on link to a sub-thread.

Connecting a cable didn't help as much as I had hoped. The main thing learned was that this isn't the page actually being stuck in a reload loop via navigation, but rather the rendering is crashing and restarting. I was also able to place breakpoints in Toggler.js which weren't reached (or at least, the process crashed regardless and things moved on -- hard to tell the difference).

Wed, May 27, 6:53 AM · JavaScript, MinervaNeue, Parsoid, Browser-Support-Apple-Safari

Tue, May 26

DLynch closed T427253: "Add topic" button mobile overlapping categories again as Resolved.

I tested this on iOS.

Tue, May 26, 9:48 AM · Skipped QA, Editing-team (Editing-current-Q4-11May-22May-2026), Regression, DiscussionTools
DLynch moved T427253: "Add topic" button mobile overlapping categories again from Decision to be made to Code review on the Editing-team (Editing-current-Q4-11May-22May-2026) board.
Tue, May 26, 9:37 AM · Skipped QA, Editing-team (Editing-current-Q4-11May-22May-2026), Regression, DiscussionTools
DLynch assigned T427253: "Add topic" button mobile overlapping categories again to Esanders.
Tue, May 26, 9:37 AM · Skipped QA, Editing-team (Editing-current-Q4-11May-22May-2026), Regression, DiscussionTools
DLynch added a comment to T426249: iOS Safari unable to load a Village Pump page when clicking on link to a sub-thread.

Some debugging:

Tue, May 26, 9:00 AM · JavaScript, MinervaNeue, Parsoid, Browser-Support-Apple-Safari
DLynch added a comment to T426249: iOS Safari unable to load a Village Pump page when clicking on link to a sub-thread.

I'd have to assume it's something about the highlighting / auto-expansion code that's clashing, presumably in ways that're more noticeable on larger (and thus slower-to-load) pages.

Tue, May 26, 6:58 AM · JavaScript, MinervaNeue, Parsoid, Browser-Support-Apple-Safari

Sat, May 23

DLynch assigned T427066: Media dialog in VisualEditor uses invalid imageinfo API parameter to Jdlrobson.

Is this causing enough of a problem that we should backport the API fix on monday?

Sat, May 23, 2:41 AM ·